[12.x] Pass LoggerInterface when constructing RoundrobinTransport instance
#56244
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As static analysis (logically) fails I'll go ahead and keep this in draft until November. |
crynobone
requested changes
Sep 11, 2025
| @@ -427,7 +427,7 @@ protected function createRoundrobinTransportOfClass(array $config, string $class | |||
| : $this->createSymfonyTransport($config); | |||
| } | |||
|
|
|||
| return new $class($transports, $config['retry_after'] ?? 60); | |||
| return new $class($transports, $config['retry_after'] ?? 60, $this->app->make(LoggerInterface::class)); | |||
There was a problem hiding this comment.
Such changes need to be PRed to master branch for the Laravel 13 release?
Laravel 12 still needs to support Symfony 7.3 and lower unless composer.json specifically set to only support 7.4
There was a problem hiding this comment.
It will still be compatible with older Symfony versions, given that passing additional parameters to a constructor is allowed in PHP (they're just discarded).
So this change is backwards compatible and will only effectively do something for those actually using 7.4+.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a follow-up to symfony/symfony#60110 which introduces an additional constructor property
loggerto theRoundRobinTransportclass, this PR ensures the app-boundLoggerInterfacewill be passed when constructing such a class.Note that this will require Symfony 7.4.0 or higher, which is due for release in November 2025. Given that passing additional parameters to constructors is allowed in PHP (they are just silently ignored), this PR as such is both backwards and forwards compatible, however at current would do effectively nothing. If therefore it is preferable to keep this as draft until (near) the release of Symfony 7.4, that is also perfectly fine with me.
I've already tested to ensure tests still pass with the following
composer.jsonpatch:"symfony/finder": "^7.2.0", "symfony/http-foundation": "^7.2.0", "symfony/http-kernel": "^7.2.0", - "symfony/mailer": "^7.2.0", + "symfony/mailer": "7.4.x-dev as 7.4.0", "symfony/mime": "^7.2.0", "symfony/polyfill-php83": "^1.31", "symfony/process": "^7.2.0",